• src/xpdev/filewrap.c

    From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Wednesday, November 11, 2026 21:04:16
    https://gitlab.synchro.net/main/sbbs/-/commit/36867a9bbfd65e97159fe358
    Modified Files:
    src/xpdev/filewrap.c
    Log Message:
    xpdev: release a CIFS server lock left behind by a failed OFD lock

    On Linux, lock() and rdlock() use OFD fcntl() locks. On a CIFS mount
    (e.g. a Synchronet tree shared over SMB, or a loopback mount of the local
    Samba share), the kernel client acquires the byte-range lock on the
    server first and only then records it in the local VFS lock table. When
    that local step fails with EAGAIN - a conflict with another open file description's lock that is still being released locally - the request
    fails but the server lock is not rolled back.

    The client also shares one SMB handle among concurrent opens of a file
    with identical flags, so the orphaned lock blocks every lock request on
    that range (EACCES) until the process closes its last descriptor for the
    file. Since every thread waiting for the lock holds the file open while it retries, the lock persists until all waiters time out. For user.tab that
    is the full lockuserdat()/rdlockuserdat() retry budget, about 106
    seconds, ending in USER_LOCK_ERROR (-104): e.g. "!ERROR -104 in
    logoutuserdat" when several SMTP sessions authenticate as the same user
    at once.

    When a non-blocking lock fails with EAGAIN on a CIFS/SMB2 filesystem,
    unlock the same range on the same descriptor, releasing the server lock.
    EACCES (a conflict reported by the server) grants nothing and is left
    alone, as are local filesystems, where unlocking after a failed request
    could trim an overlapping lock the descriptor already holds.

    Reproduced with two threads repeatedly taking a shared lock, then an
    exclusive lock, on the same 1000-byte record of a file on a CIFS mount
    (Linux 6.1, Samba 4.22): the first EAGAIN stalled every run, within a few thousand iterations. With this change, 18,200 iterations including 7
    EAGAIN failures completed without a stall. Process-associated F_SETLK
    locks never stalled, as they cannot conflict within one process locally.

    Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
    --- SBBSecho 3.38-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)